fix: captured tagged alternation in field produces tagged union#269
Merged
fix: captured tagged alternation in field produces tagged union#269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
field: [Tag: ...] @capproduced rawNodeinstead of tagged union{$tag, $data}unwrap_field_value()helper to look throughFieldExprwhen detecting enum-producing alternationsEndEnumfor correct tagged union capture semanticsWhy
Parser intentionally treats
field: expr @capas(field: expr) @capso quantifiers work on fields (e.g.,decorator: (x)*). This meant captures on field values wrappedFieldExpr, andbuild_capture_effectsdidn't look through it to detect the enum-producing alternation inside.Notes
Two complementary changes:
capture.rs:unwrap_field_value()+ updatedcreates_structured_scopecheckexpressions.rs: New code pathinner_is_scope_creating_scalarfor enum capture placement